Make translation fields compatible with 1.8 migrations. #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnTeQuAk
force-pushed
the
bugfix/translations-fields-1.8
branch
from
69152ff
to
f9c009d
Compare
EnTeQuAk
force-pushed
the
bugfix/translations-fields-1.8
branch
from
51f7645
to
f06c918
Compare
|
That does fix the issue I was having, but is there a way to write a test for this ? |
|
yeah, there are some ways. I didn't have the time to do that yesterday, I found a few nice reference tests in the django test suite and I'll update the PR in a bit with proper tests. |
|
Sorry for the wait, @diox I added a few tests inspired by how django does it. They fail properly if the actual patch is removed. |
|
r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.