Stop setting _latest_version field, remove it from Addon model #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #3751 The column is kept for now because the migration is costly, but since it's NULLable it should not be a problem. Deleting the column is a follow-up task in the same issue.
diox
force-pushed
the
stop-setting-latest-version
branch
from
9f5c506
to
e7c532a
Compare
EnTeQuAk
approved these changes
Nov 17, 2016
| @@ -1820,7 +1820,7 @@ def test_current_version_is_listed_only(self): | |||
|
|
|||
| def test_firefox_versions(self): | |||
| self.setup_new_version() | |||
| assert self.addon.update_version() | |||
| self.addon.update_version() | |||
There was a problem hiding this comment.
With latest_version no longer set by update_version(), that assertion (which wasn't very useful in that test) will fail.
There was a problem hiding this comment.
Ah, I was just reading the docs and they still mention that the method returns True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of mozilla/addons#3621
The column is kept for now because the migration is costly, but since it's NULLable it should not be a problem. Deleting the column is a follow-up task in the same issue.