Add addon and evolution callout #4230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muffinresearch
commented
Jan 5, 2017
| @medium: ~"only screen and (min-width: 700px)"; | ||
| @large: ~"only screen and (min-width: 1024px)"; | ||
| @retina: ~"only screen and (min-device-pixel-ratio: 2)"; | ||
| @retina: ~"only screen and (min-resolution: 1.5dppx)"; |
There was a problem hiding this comment.
This is the proper way to do resolution queries since min-device-pixel-ratio is old hat.
EnTeQuAk
approved these changes
Jan 6, 2017
| @medium: ~"only screen and (min-width: 700px)"; | ||
| @large: ~"only screen and (min-width: 1024px)"; | ||
| @retina: ~"only screen and (min-device-pixel-ratio: 2)"; | ||
| @retina: ~"only screen and (min-resolution: 1.5dppx)"; |
|
|
||
| .DevHub-content-copy { | ||
| position: relative; | ||
| z-index: 4; | ||
| } | ||
|
|
||
| .DevHub-callout-box { | ||
| border: 8px solid #FDC900; |
There was a problem hiding this comment.
I wonder if this color code should be extracted into a variable.
There was a problem hiding this comment.
Yeah, we're going to need this more. I'll sort that.
| margin: 0 -20px -20px; | ||
|
|
||
| @media @medium { | ||
| box-shadow: 8px 8px 0 0 rgba(0,0,0,0.15); |
There was a problem hiding this comment.
whitespaces after comma in rgba section?
|
|
||
| .DevHub-content-container--manage { | ||
| flex-direction: column; | ||
| background-image: url(../../../img/developers/new-landing/manage-addon.png); |
There was a problem hiding this comment.
Interesting that the highlighting doesn't work but I don't see any syntax problem.
There was a problem hiding this comment.
Yeah a lot of CSS syntax grammar seems to trail, I have similar issues with the newer stuff.
muffinresearch
force-pushed
the
add-manage-addon-and-evolution
branch
from
e0f92e5
to
3e717c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#3865
I still need to add the ladder image, but I think this is mostly ready otherwise.
Full spec tightening + cleanups can be a follow-up too.
Looks like this: