Remove latest_version, sitespecific and is_listed columns from 'addons' #4596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Those columns have already been removed in dev/stage/prod environments)
eviljeff
reviewed
Feb 6, 2017
| ALTER TABLE addons drop foreign key latest_version_refs_versions; | ||
| END IF; | ||
| IF EXISTS (SELECT * FROM information_schema.table_constraints WHERE table_schema = (SELECT DATABASE()) AND table_name = 'addons' AND constraint_name = 'latest_version_refs_id_46aa95ab') THEN | ||
| ALTER TABLE addons drop foreign key latest_version_refs_id_46aa95ab; |
There was a problem hiding this comment.
is id_46aa95ab; consistent across dev, stage & prod at least? (locally?)
There was a problem hiding this comment.
It's what django generates, so it should be consistent across all envs that used syncdb (you can check locally if you still have it); the one above, latest_version_refs_versions is what we had on dev/stage/prod for some reason.
eviljeff
approved these changes
Feb 6, 2017
|
gah, I'm not exactly an expert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Those columns have already been removed in dev/stage/prod environments)
Fix mozilla/addons#3914 mozilla/addons#3485, mozilla/addons#3621