Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I5224: WebExtension compatibility label is not correctly RTL #6192

Merged
merged 1 commit into from
Aug 18, 2017
Merged

I5224: WebExtension compatibility label is not correctly RTL #6192

merged 1 commit into from
Aug 18, 2017

Conversation

tsl143
Copy link
Contributor

@tsl143 tsl143 commented Aug 18, 2017

Fixes mozilla/addons#4276

Need to explicitly put direction:ltr to get the + direction as required in the bug description.

Before :
screen shot 2017-08-18 at 7 34 05 am

After:
screen shot 2017-08-18 at 7 33 40 am

EnTeQuAk
EnTeQuAk approved these changes Aug 18, 2017
View reviewed changes
Copy link
Contributor

@EnTeQuAk EnTeQuAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my, it took me ages to find that subtle difference in the screenshots.

Looks great, thanks a lot for the patch!

@EnTeQuAk EnTeQuAk merged commit a3384e2 into mozilla:master Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnTeQuAk EnTeQuAk EnTeQuAk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebExtension compatibility label is not correctly RTL
2 participants
@tsl143 @EnTeQuAk