Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Add JWT Authentication to Reviewer API Endpoints. #14833

Closed
1 task
chrstinalin opened this issue Jun 6, 2024 · 2 comments · Fixed by mozilla/addons-server#22328
Closed
1 task

[Task]: Add JWT Authentication to Reviewer API Endpoints. #14833

chrstinalin opened this issue Jun 6, 2024 · 2 comments · Fixed by mozilla/addons-server#22328
Assignees
Labels
qa:not_needed repository:addons-server Issue relating to addons-server
Milestone

Comments

@chrstinalin
Copy link

chrstinalin commented Jun 6, 2024

Description

Currently, the reviewers endpoints (specifically /api/v5/reviewers/addon/(int: addon_id)/versions/(int: version_id)/) returns a response of "detail": "Authentication credentials were not provided." and namely lacks the ability to support JWT auth outlined here.

Acceptance Criteria

Acceptance Criteria

Checks

  • If the issue is ready to work on, I have removed the "needs:info" label.

┆Issue is synchronized with this Jira Task

@chrstinalin chrstinalin added the repository:addons-server Issue relating to addons-server label Jun 6, 2024
@diox
Copy link
Member

diox commented Jun 6, 2024

/api/v5/reviewers/addon/(int: addon_id)/versions/(int: version_id)/ will go away when code-manager is removed so it's probably not necessary to change it.

What we should do is:

  • Document that /api/v5/reviewers/addon/(int: addon_id)/file/(int: file_id)/validation/ exists
  • Add JWT authentication to it
  • Make sure it's covered by tests

@diox
Copy link
Member

diox commented Jun 7, 2024

Marking as not needing QA as @chrstinalin can verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:not_needed repository:addons-server Issue relating to addons-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants