Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Improvements to our Docker build #1992

Closed
KevinMind opened this issue Feb 19, 2024 · 8 comments
Closed

Various Improvements to our Docker build #1992

KevinMind opened this issue Feb 19, 2024 · 8 comments
Assignees
Labels
repository:addons-server Issue relating to addons-server

Comments

@KevinMind
Copy link
Contributor

KevinMind commented Feb 19, 2024

Description

While investigating/implementing several issues that rely on our docker build setup:

I found various improvements that can be made to our docker build setup. These improvements can be split into 2 categories:

  • incremental improvements
  • step-wise improvements

Where the former are small improvements to the speed or bandwidth requirements of the existing overall build strategy, and the latter are larger architectural changes which imply both bigger gains and bigger cost, risk, etc.

This issue is aiming to track PRs for the former. These are changes which we can safely ship today without seriously risking our overall production/ci/local development pipeline.

### Tasks
- [x] Verify docker image in CI
- [ ] Split docker build into cache efficient stages
- [ ] Extract dev/prod/build apt dependencies per stage.
- [ ] https://github.com/mozilla/addons-server/issues/22060
- [x] Merge requirements files
- [x] Parallelize locale compilation
- [ ] Verify node/npm/python/pip versions are correct regardless of environment
- [ ] https://github.com/mozilla/addons-server/issues/21940
- [ ] https://github.com/mozilla/addons-server/issues/21955
- [ ] https://github.com/mozilla/addons-server/issues/21981
- [ ] https://github.com/mozilla/addons-server/issues/21997
- [ ] https://github.com/mozilla/addons-server/issues/22073

┆Issue is synchronized with this Jira Task

@KevinMind
Copy link
Contributor Author

@diox
Copy link
Member

diox commented Feb 26, 2024

@KevinMind
Copy link
Contributor Author

https://docs.docker.com/build/guide/mounts/

Is there something specific to see here, or just wanting to link the documentation?

@diox
Copy link
Member

diox commented Feb 26, 2024

Sorry I just wanted to link to the docs about --mount somewhere for reference - and I didn't want to edit your own comment.

@KevinMind
Copy link
Contributor Author

Bug with COPY over caching moby/moby#33107

@KevinMind
Copy link
Contributor Author

@KevinMind
Copy link
Contributor Author

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 3, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

3 participants