Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove puente #8747

Closed
willkg opened this issue Apr 4, 2022 · 5 comments · Fixed by mozilla/addons-server#19097
Closed

Remove puente #8747

willkg opened this issue Apr 4, 2022 · 5 comments · Fixed by mozilla/addons-server#19097
Assignees
Milestone

Comments

@willkg
Copy link
Member

willkg commented Apr 4, 2022

I'm the current maintainer of puente. I'm maintaining too many things and I haven't used Puente in years, so I'm looking at either:

  • passing maintenance to someone else
  • or, ending the project

Puente was built to make it possible for projects to transition off of Tower. It was always intended to be a temporary stop-gap to using existing tooling provided in Django, Babel, and Jinja2. It's possible it might not be needed anymore.

If you're interested in taking over maintenance, that'd be great! If no one takes over, I'll shut down the project in May 2022.

@diox diox self-assigned this Apr 7, 2022
@diox diox added this to the 2022.04.14 milestone Apr 7, 2022
@diox
Copy link
Member

diox commented Apr 7, 2022

I think we can get rid of it.

https://github.com/diox/olympia/tree/no-puente gets us 90% of the way there, but extraction fails for some jinja templates because jinja's extractor doesn't run with our jinja config like puente would, so some extensions fail to load, which causes the whole template to be ignored.

It's something that ideally would be provided by django-jinja maybe ? But we can work around that by using our own custom extractor that would load the config. That would also avoid the repetition I had to do in babel.cfg for all the jinja config bits.

@willkg
Copy link
Member Author

willkg commented Apr 7, 2022

If it helps, you can copy whatever you need from Puente into addons-server--it's all Mozilla-owned code.

I'll note that addons-server doesn't need it in the Puente issue. Thanks!

@ioanarusiczki
Copy link

@diox Is this qa not needed?

@diox
Copy link
Member

diox commented Apr 12, 2022

@ioanarusiczki one thing you can test is ensure content is properly translated across devhub where it was before.

@ioanarusiczki
Copy link

@diox I looked over dev hub pages in several languages and I did not find issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants