Remove puente: add necessary babel configuration instead #19097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diox
commented
Apr 11, 2022
| def test_extract_jinja_no_options(): | ||
| # Doesn't actually extract, just tests that extract_jinja() doesn't fail | ||
| # when converting our settings in options for the underlying function. | ||
| extract_jinja(BytesIO(), DEFAULT_KEYWORDS, ['L10n:'], {}) |
There was a problem hiding this comment.
It's out of scope for this but I think we should consider run a true extract (without merging the locale files) as part of the test suite. This would ensure we can actually run the extraction at all times on master branch.
There was a problem hiding this comment.
eviljeff
approved these changes
Apr 11, 2022
| @@ -551,52 +555,10 @@ def get_db_config(environ_var, atomic_requests=True): | |||
| 'https://addons.mozilla.org/api/v5/shelves/editorial' | |||
| ) | |||
|
|
|||
| # Filename where the strings will be stored. Used in puente config below. | |||
| # Filename where the strings will be stored. Used in extract_content_strings | |||
| # management command, but note that the filename is hardcoded in babel.cfg. | |||
There was a problem hiding this comment.
it's a shame we can't define/generate all the babel config in one place 😞
There was a problem hiding this comment.
We could generate the babel config, but that's one more cog in the machine... Alternatively we could do what puente used to do and provide our own extract command, but I thought it'd be better if we tried to stay closer to how babel works...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#8747