Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin tools: CinderPolicy-ReviewActionReason changes #9474

Closed
wagnerand opened this issue Feb 19, 2024 · 2 comments · Fixed by mozilla/addons-server#21919
Closed

Admin tools: CinderPolicy-ReviewActionReason changes #9474

wagnerand opened this issue Feb 19, 2024 · 2 comments · Fixed by mozilla/addons-server#21919

Comments

@wagnerand
Copy link
Member

wagnerand commented Feb 19, 2024

  • On admin/models/reviewers/reviewactionreason/ please add the linked CinderPolicy parent as text and sub-policy name as linked text.
  • On admin/models/abuse/cinderpolicy please add the linked ReviewActionReason name as linked text. Note that there might be more than one ReviewActionReason for one CinderPolicy.
  • The CinderPolicy FK on the ReviewActionReason should only be mandatory if the ReviewActionReason is enabled.
    • Changing ReviewActionReason.is_active from True to False should not require a CinderPolicy FK to be added or present.
    • Changing ReviewActionReason.is_active from False to True should require a CinderPolicy FK to be added or present.

┆Issue is synchronized with this Jira Task

@alexandruschek
Copy link

Hello,

I tested this on -DEV and it looks ok.
If the: is active flag is set to false the cinder policy is not required
If the: is active is set to true, a cinder policy is required and saving is not possible until one is added.
Linked cinder policy column was added in review action reason.

Marking this as verified fixed, thank you!

@KevinMind
Copy link
Contributor

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants