Skip to content
This repository has been archived by the owner on Feb 1, 2019. It is now read-only.

Dictionary with wrong "type" can be submitted #407

Closed
ValentinaPC opened this issue Mar 11, 2016 · 3 comments · Fixed by #408
Closed

Dictionary with wrong "type" can be submitted #407

ValentinaPC opened this issue Mar 11, 2016 · 3 comments · Fixed by #408
Assignees
@wagnerand

Comments

@ValentinaPC
Copy link

Steps to reproduce:

  1. Sign in to AMO-dev page https://addons-dev.allizom.org/en-US/
  2. Submit a dictionary with a wrong "type" set (i.e. type=2)

Expected results:
The dictionary cannot be submitted because the "type" is wrong.

Actual results:
The dictionary can be submitted.

Notes/Issues:
Verified on AMO-dev FF45(Win 7).
Screenshot for this issue:
2016-03-11_1650
@wagnerand wagnerand mentioned this issue Mar 11, 2016
Merged
@ValentinaPC
Copy link
Author

Not sure if the fix landed on AMO-dev FF45(Win 7), because I am still able to reproduce.
@muffinresearch ?

@wagnerand
Copy link
Member

I just updated amo-validator, so the fix should be on AMO-dev now. Could you retry, please?

@ValentinaPC
Copy link
Author

Verified as fixed on AMO-dev FF45(Win 7). Tried with type like "2", "4","8","32", "64", "128" and none.
Postfix screenshots:
2016-03-14_1541
2016-03-14_1540

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wagnerand wagnerand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fail if dictionaries have missing *or wrong* type
3 participants
@muffinresearch @wagnerand @ValentinaPC