Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer non-optional UTF8 String <-> Data conversion. #6254

Closed
wants to merge 1 commit into from
Closed

Prefer non-optional UTF8 String <-> Data conversion. #6254

wants to merge 1 commit into from

Conversation

mhammond
Copy link
Member

Hopefully addresses the swift-lint errors.

Fix via realm/SwiftLint#5263

@mhammond
Prefer non-optional UTF8 String <-> Data conversion.
5f58994 
Hopefully addresses the swift-lint errors.

Fix via realm/SwiftLint#5263
@mhammond mhammond requested a review from jeddai May 27, 2024 21:15
@mhammond mhammond marked this pull request as ready for review May 27, 2024 21:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.85%. Comparing base (d73a4c7) to head (5f58994).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6254   +/-   ##
=======================================
  Coverage   50.85%   50.85%           
=======================================
  Files         112      112           
  Lines       11811    11811           
=======================================
  Hits         6006     6006           
  Misses       5805     5805

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linabutler linabutler mentioned this pull request May 29, 2024
Merged
5 tasks
linabutler
linabutler approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@linabutler linabutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@linabutler linabutler added this pull request to the merge queue May 30, 2024
@linabutler linabutler removed this pull request from the merge queue due to a manual request May 30, 2024
@linabutler
Copy link
Member

Actually, it looks like SwiftLint is reverting this rule: realm/SwiftLint#5601

While I think it might actually make sense for us in both cases—JSONSerialization and JSONEncoder should always return valid UTF-8 encoded byte sequences—I wouldn’t want to merge this, and then discover it’s warning again the other way 😅

Shall we give this a bit more time?

@skhamis skhamis mentioned this pull request Jun 7, 2024
Merged
5 tasks
@linabutler
Copy link
Member

Superseded by #6269. It looks like the SwiftLint reversion is taking a bit of time to merge, so let's disable the rule for now. That way, we shouldn't need to do anything once the rule is changed back.

@linabutler linabutler closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linabutler linabutler linabutler approved these changes

@jeddai jeddai Awaiting requested review from jeddai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhammond @codecov-commenter @linabutler