Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bad swiftlint rule #6269

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Conversation

skhamis
Copy link
Contributor

@skhamis skhamis commented Jun 7, 2024

While #6254 tries to fix the issue. Turns out the rule might be reversed in swiftlint mentioned by @linabutler #6254 (comment)

realm/SwiftLint#5601 has more discussion about the issues with the lint. For the sake of our PRs, lets just disable the rule for now (as we don't know when it'll get merged and version bumped). There's a broader discussion about locking swiftlint to prevent these kind of issues here https://bugzilla.mozilla.org/show_bug.cgi?id=1900934 but that'll take a little more discussion before we do anything substantial

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@skhamis skhamis requested review from a team and tarikeshaq June 7, 2024 21:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.64%. Comparing base (71578be) to head (68cfc19).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6269   +/-   ##
=======================================
  Coverage   22.64%   22.64%           
=======================================
  Files         330      330           
  Lines       29814    29814           
=======================================
  Hits         6751     6751           
  Misses      23063    23063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@linabutler linabutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this instead—thanks! (Sorry, @mhammond! 😅) That way, we won't need to change our code, now or when SwiftLint reverts the rule.

@linabutler linabutler added this pull request to the merge queue Jun 7, 2024
Merged via the queue into mozilla:main with commit 9884a6d Jun 8, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants