This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Fix bug 1138531: Add an email block list feature. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgmize r? |
| cache_key = 'email_block_list' | ||
| block_list = email_block_list_cache.get(cache_key) | ||
| if block_list is None: | ||
| block_list = BlockedEmail.objects.values_list('email_domain', flat=True) |
There was a problem hiding this comment.
micro-optimization nit: I would go ahead and convert this to an actual list-- no point in pickling/unpickling the queryset object itself. Since you're using LocMemCache the performance impact will be negligible, so not a blocker, but it will help if you ever switch to memcache or redis because you'll be sending less data over the wire.
There was a problem hiding this comment.
Huh... yeah. Good call. I was just wrong and thought that when flat=True was passed it returned a list object.
|
r+, nice work. |
pmclanahan
force-pushed
the
add-block-list-1138531
branch
from
b9edc68
to
b9c8b48
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.