This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Fix bug 1065624: Remove subscriber data from db. #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| operations = [ | ||
| migrations.DeleteModel( | ||
| name='Subscriber', |
There was a problem hiding this comment.
I recommend moving this to a separate commit, to be deployed after the removal from news/models.py.
pmclanahan
force-pushed
the
remove-subscriber-db
branch
from
c2731ea
to
7caf658
Compare
Subscriber data should only be in ExactTarget.
Remove nose et. al.
pmclanahan
force-pushed
the
remove-subscriber-db
branch
3 times, most recently
from
0fe3129
to
2184809
Compare
|
@jgmize I think I've addressed your concerns so far. Thanks for the review. |
|
@pmclanahan would you mind excluding the migrations folder from the coverage check? |
Ignore migrations in coverage reports.
pmclanahan
force-pushed
the
remove-subscriber-db
branch
from
2184809
to
b9853bb
Compare
|
I've updated the coverage config. Seems to be working. @jgmize you think this is good enough now to merge into |
|
Yes, this lgtm for merging into the 12factor branch. Nice work :) |
jgmize
added a commit
that referenced
this pull request
Aug 13, 2015
Fix bug 1065624: Remove subscriber data from db.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #141 and is based on WIP branch (12factor) for work
related to readying the site for deployment to heroku or deis.