Fix bug 1065624: Remove subscriber data from db. #141
Conversation
Subscriber data should only be in ExactTarget.
|
@jgmize this is a big step on the way to the move away from generic cluster. if you get some time I'd appreciate at least some first pass thoughts. |
|
NOTE: the move from django-nose to pytest-django is because the former was giving me fits. pytest seems much more well maintained at least as far as django integration is concerned. |
| @@ -119,6 +119,7 @@ def on_failure(self, exc, task_id, args, kwargs, einfo): | |||
| The return value of this handler is ignored. | |||
|
|
|||
| """ | |||
| print 'CALLED on_failure!!!!!!!!!!' | |||
There was a problem hiding this comment.
this was probably left in accidentally?
|
Overall this this is looking good so far on visual inspection, but I'd like to get together and discuss testing and deployment plans. Are you wanting to test and deploy #140 first and then tackle this? |
Remove nose et. al.
pmclanahan
force-pushed
the
remove-subscriber-db
branch
from
12272ac
to
c2731ea
Compare
| @@ -7,22 +7,27 @@ | |||
| unsubscribe, user) | |||
|
|
|||
|
|
|||
| def token_url(url_prefix, *args, **kwargs): | |||
There was a problem hiding this comment.
@jgmize this look okay? I simplified it a bit more than you'd suggested.
|
I do think #140 should go first, however, we're still not on the new Py2.7 cluster for stage and prod. So this will need to stay here until that's done at least. After this I've got a bit more to do to get it heroku-ready, then I'll do an attempt at deploying elsewhere. |
|
Maybe I should resubmit this as a PR against the django-1.7 branch... |
|
I've created the |
|
Closing in favor of #142. |
This relies on #140 and includes the commit from there.