This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Fix bug 1188047: Add accept_lang support to subscribe. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgmize r? when you get a chance. |
Also updates get_best_language to also search for 2 letter languages in our supported list.
pmclanahan
force-pushed
the
add-accept-lang-subscribe-1188047
branch
from
0c289d2
to
b90c222
Compare
| @@ -485,8 +498,11 @@ def get_best_language(languages): | |||
| if not languages: | |||
| return None | |||
|
|
|||
| # try again with 2 letter languages | |||
| languages_2l = [lang[:2] for lang in languages] | |||
There was a problem hiding this comment.
Would you mind confirming that we don't need to worry about 3 letter language codes here? I'm guessing not, just double checking.
There was a problem hiding this comment.
Confirmed. So far we only deal with a small list of languages, and none are 3 letter.
|
r+, nice work. My question about language codes wouldn't be a blocker for merge even if it were needed, as that could be easily added later. I like the simplicity of including the accept_lang in the POST data instead of the header. |
pmclanahan
pushed a commit
that referenced
this pull request
Aug 10, 2015
…8047 Fix bug 1188047: Add accept_lang support to subscribe.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates get_best_language to also search for 2 letter
languages in our supported list.