Add configurable timeout to ET requests. #99
Conversation
| security = Security() | ||
| token = UsernameToken(inst.user, inst.pass_) | ||
| security.tokens.append(token) | ||
| inst.client.set_options(wsse=security) | ||
| inst.client = Client(WSDL_URL, wsse=security, timeout=ET_TIMEOUT) |
There was a problem hiding this comment.
While this looks good in theory, I can't find where setting the timeout here actually does something in https://github.com/mozilla/basket-lib/blob/master/packages/suds/suds/client.py other than just storing the key value pair in the Client.options dict. What am I missing?
There was a problem hiding this comment.
I had to dive deep. It eventually passes it to urllib2 I believe.
There was a problem hiding this comment.
There was a problem hiding this comment.
Right, but Client.options aren't being passed during the HttpAuthenticated instantiation; they are separate dicts.
There was a problem hiding this comment.
Hmm... maybe you're right. Could set the default timeout via the socket module. Not sure if it'd be overridden. Another option might be to look into upgrading suds. Not sure. Good catch though. I really thought I'd traced it all the way back :(
|
I believe this one will work. |
Add configurable timeout to ET requests.
|
I believe it will, too :) |
@jgmize I think this will help too. Should keep basket from churning forever.
I'd still like to check into catching this particular timeout and catching it
with statsd or something.