Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update division operators in Sass/SCSS #10459

Closed
craigcook opened this issue Sep 14, 2021 · 1 comment
Closed

Update division operators in Sass/SCSS #10459

craigcook opened this issue Sep 14, 2021 · 1 comment
Assignees
@maureenlholland
Labels
Infra Infrastructure
Milestone
Technical Roadmap...

Comments

@craigcook
Copy link
Member

Description

Using / as a division operator is being deprecated in Sass. It still works for now but will throw a warning during compiling.

We should weed out all our uses of / for division in our Sass/SCSS and change them to the new math.div() function. Sass provides a migration tool that should help automate this but we'll want to take care to make sure nothing breaks along the way.

The current version of node-sass doesn't seem to be using the latest Sass yet so it doesn't show any warnings at this time, but it'll become an issue in the near future. We might as well get ahead of it.
@craigcook craigcook added the Infra Infrastructure label Sep 14, 2021
@alexgibson
Copy link
Member

See also: #10469

@alexgibson alexgibson added this to the Technical Roadmap Q4 2021 milestone Sep 16, 2021
@maureenlholland maureenlholland self-assigned this Oct 6, 2021
maureenlholland added a commit to maureenlholland/bedrock that referenced this issue Oct 6, 2021
@maureenlholland
Update scss division (fixes mozilla#10459)
cdb8502
@maureenlholland maureenlholland mentioned this issue Oct 6, 2021
Merged
maureenlholland added a commit to maureenlholland/bedrock that referenced this issue Oct 7, 2021
@maureenlholland
Update to dart-sass, update scss division (fixes mozilla#10459, mozil…
4417ca1 
…la#10469)
maureenlholland added a commit to maureenlholland/bedrock that referenced this issue Oct 7, 2021
@maureenlholland
Update to dart-sass, update scss division (fixes mozilla#10459, mozil…
9928fa5 
…la#10469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maureenlholland maureenlholland

Labels
Infra Infrastructure
Projects
None yet
Milestone
Technical Roadmap Q4 2021
Development

No branches or pull requests
3 participants
@craigcook @alexgibson @maureenlholland