Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove accounts popup in /new #14246

Closed
Tracked by #14229
stephaniehobson opened this issue Feb 23, 2024 · 0 comments · Fixed by #14289
Closed
Tracked by #14229

Remove accounts popup in /new #14246

stephaniehobson opened this issue Feb 23, 2024 · 0 comments · Fixed by #14289
Assignees
@stephaniehobson

Comments

@stephaniehobson
Copy link
Contributor

stephaniehobson commented Feb 23, 2024 •
edited
Loading

For Firefox users who are not signed into their Mozilla account clicking the download button on /new triggers a pop-up which encourages them to get an account. This made more sense when it was a Firefox account but now we should just get out of their way.

Remove the pop up and associated code.
Screenshot 2024-02-23 at 11 42 47
@stephaniehobson stephaniehobson mentioned this issue Feb 23, 2024
Open
@stephaniehobson stephaniehobson self-assigned this Feb 23, 2024
stephaniehobson added a commit that referenced this issue Mar 5, 2024
@stephaniehobson
Remove accounts popup from download flow (Fix #14246)
c020be7
@stephaniehobson stephaniehobson mentioned this issue Mar 5, 2024
Merged
stephaniehobson added a commit that referenced this issue Mar 7, 2024
@stephaniehobson
Remove accounts popup from download flow (Fix #14246)
4848b14
stephaniehobson added a commit that referenced this issue Mar 7, 2024
@stephaniehobson
Remove accounts popup from download flow (Fix #14246)
3da42a5
stephaniehobson added a commit that referenced this issue Mar 13, 2024
@stephaniehobson
Remove accounts popup from download flow (Fix #14246) (#14289)
2ea351e 
* Remove accounts popup from download flow (Fix #14246)

- Remove JS, CSS, and associated HTML
- Remove associated tests
- Remove a few other unused strings that use the "Join Firefox" language
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephaniehobson stephaniehobson

Labels
None yet
Projects
Moz.org Refresh
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove accounts popup from download flow (Fix #14246) mozilla/bedrock
1 participant
@stephaniehobson