Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove accounts popup from download flow (Fix #14246) #14289

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Remove accounts popup from download flow (Fix #14246) #14289

merged 2 commits into from
Mar 13, 2024

Conversation

stephaniehobson
Copy link
Contributor

@stephaniehobson stephaniehobson commented Mar 5, 2024 •
edited
Loading

One-line summary

Remove accounts popup from download flow.

Significant changes and points to review

  • Remove JS, CSS, and associated HTML
  • Remove associated tests
  • Remove a few other unused strings that use the "Join Firefox" language

Issue / Bugzilla link

Fix #14246

Testing

  1. Using Firefox but don't be signed into a Mozilla account
  2. Try to download from /new
  3. Get a download (instead of the popup)
  • Make sure I didn't break downloads 😬
  • There was CSS on the page for a second modal (other-platforms) but I can't find the HTML that goes with that so I removed it but I'm worried I am missing something but I really can't find it.

✅ Integration tests.

@stephaniehobson stephaniehobson marked this pull request as ready for review March 7, 2024 04:39
@stephaniehobson stephaniehobson added Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Mar 11, 2024
alexgibson
alexgibson approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@alexgibson alexgibson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call removing this now. It was never my favorite "feature" so I'm glad we can at last retire it 😉 r+wc 💯

@stephaniehobson stephaniehobson merged commit 2ea351e into main Mar 13, 2024
4 checks passed
@stephaniehobson stephaniehobson deleted the popup branch March 13, 2024 04:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgibson alexgibson alexgibson approved these changes

Assignees
No one assigned
Labels
Needs Review Awaiting code review Review: XS Code review time: up to 30min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove accounts popup in /new
2 participants
@stephaniehobson @alexgibson