Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German: Firefox Nightly Firstrun page contains obsolete links #9930

Closed
peiying2 opened this issue Feb 16, 2021 · 4 comments · Fixed by #9955
Closed

German: Firefox Nightly Firstrun page contains obsolete links #9930

peiying2 opened this issue Feb 16, 2021 · 4 comments · Fixed by #9955
Labels
Bug 🐛 Something's not working the way it should

Comments

@peiying2
Copy link
Contributor

Description

Check the discussion here: https://bugzilla.mozilla.org/show_bug.cgi?id=1692600

Though firefox/nightly/firstrun.ftl has been migrated, https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templates/firefox/nightly/firstrun.de.html is a hardcoded page which contains obsolete links.

Expected result

Either remove the template, and resort to the page offered to the other locales. The page in Pontoon is already localized. OR update the hard coded page and remove the links stated in bug https://bugzilla.mozilla.org/show_bug.cgi?id=1692600

@peiying2 peiying2 added the Bug 🐛 Something's not working the way it should label Feb 16, 2021
@Archaeopteryx
Copy link
Contributor

Recommendations:

Drop:

  • @mozilla_deutsch
  • Facebook
  • Aktuelle Veranstaltungen - could be added again when they resume.

Replace:

The text above should get a small modification:

Old:

Unsere Projekte bieten einige vielfältige Möglichkeiten, wie sich wirklich jeder aktiv einbringen kann: Helfen Sie Anwendern von Mozilla-Software, arbeiten Sie an der Übersetzung der Mozilla-Software von Webseiten mit oder planen Sie Veranstaltungen für das WebMaker-Projekt.

New:

Unsere Projekte bieten einige vielfältige Möglichkeiten, wie sich wirklich jeder aktiv einbringen kann: Helfen Sie Anwendern von Mozilla-Software oder arbeiten Sie an der Übersetzung der Mozilla-Software und -Webseiten mit.

Can create a pull request later.

@alexgibson
Copy link
Member

Pull requests are always welcome if anyone in the community would like to make these updates

@PFischbeck
Copy link
Contributor

I am working on a PR to resolve this. However, in the process I have noticed that there is an invisible h3, which I have partially highlighted here:
hidden-h3

The same issue appears with custom firstrun pages of other locales. What is the correct fix for this? Add mzp-t-dark to the div for every affected locale?

@alexgibson
Copy link
Member

The same issue appears with custom firstrun pages of other locales. What is the correct fix for this? Add mzp-t-dark to the div for every affected locale?

Good catch! Looks like this is a regression from a recent Protocol update that changed the way pages do theming. Adding a class of mzp-t-dark to the .locale-specific container DIV seems like a quick and simple enough solution to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something's not working the way it should
Projects
None yet
4 participants