Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to Lockwise, replace with VPN [fix #10166] #10289

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Remove references to Lockwise, replace with VPN [fix #10166] #10289

merged 1 commit into from
Jun 21, 2021
+293 −117

Conversation

craigcook
Copy link
Member

Description

Replaces Lockwise with Mozilla VPN on:

  • Sticky promo
  • /firefox/
  • /firefox/products/
  • /firefox/privacy/products/
  • /firefox/accounts/

Issue / Bugzilla link

#10166

Testing

http://localhost:8000/firefox/
http://localhost:8000/firefox/products/
http://localhost:8000/firefox/privacy/products/
http://localhost:8000/firefox/accounts/

@craigcook craigcook added the WIP 🚧 Pull request is still work in progress label Jun 17, 2021
@mozmeao-heroku-bot mozmeao-heroku-bot temporarily deployed to www-demo-pr-10289 June 17, 2021 15:49 Inactive
@craigcook
Copy link
Member Author

craigcook commented Jun 17, 2021 •
edited
Loading

To do:

  • finalize copy/strings
  • fix/update tests

@mozmeao-heroku-bot mozmeao-heroku-bot temporarily deployed to www-demo-pr-10289 June 17, 2021 17:22 Inactive
@craigcook craigcook added Needs Review Awaiting code review Review: XS Code review time: up to 30min and removed WIP 🚧 Pull request is still work in progress labels Jun 17, 2021
maxxcrawford
maxxcrawford approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@maxxcrawford maxxcrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified across those pages – including the sticky promo. ✅

image

@alexgibson alexgibson merged commit 575a9fb into master Jun 21, 2021
@alexgibson alexgibson deleted the 10166-remove-lockwise branch June 21, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxxcrawford maxxcrawford maxxcrawford approved these changes

Assignees
No one assigned
Labels
Needs Review Awaiting code review Review: XS Code review time: up to 30min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@craigcook @maxxcrawford @alexgibson @mozmeao-heroku-bot