Adds functional tests for the community signup page #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| }); | ||
|
|
||
| casper.test.begin('Contribute Sigup, Browser validation prevents form submission: ' + url, 1, function suite(test) { |
There was a problem hiding this comment.
What do you think to losing this particular test? I don't think we strictly need to test that native browser form validation works, especially given that we have a test below to make sure things still work correctly when a browser does not support said feature?
There was a problem hiding this comment.
Makes sense, let's forgo these.
|
r+! |
alexgibson
added a commit
that referenced
this pull request
Jul 21, 2015
…-signup Adds functional tests for the community signup page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexgibson r? Whilst writing these tests, I discovered and logged 4 bugs, yeah tests!