bug-1189121-remove-moz-expressions-from-bedrock #3240
Conversation
|
Thank You @alexgibson |
|
Added a commit to tidy up a bit and removed some other vendor cruft. Thanks again @TheJJ100100! |
|
Thanks @alexgibson |
|
Any reason this has not been merged yet? Is it the two commits? |
|
@schalkneethling - just needs review. I'm preserving the two commits so @TheJJ100100 gets credit for the bug. |
|
@alexgibson I was wondering too :) On 26 August 2015 at 14:42, Alex Gibson notifications@github.com wrote:
Joseph Bywater / A Student [image: Twitter] https://twitter.com/thejj100100 [image: Youtube] |
| background-image: -webkit-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1)); | ||
| background-image: -moz-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1)); | ||
| background-image: -ms-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1)); | ||
| background-image: -o-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1)); | ||
| background-image: linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1)); |
There was a problem hiding this comment.
Actually this is intentional as per our CSS styleguide formatting
There was a problem hiding this comment.
Oh, alrighty. Was not aware of that.
There was a problem hiding this comment.
@alexgibson @schalkneethling What happened? I did what I was told :P
On 26 August 2015 at 18:08, Schalk Neethling notifications@github.com
wrote:
In media/css/sandstone/sandstone-resp.less
#3240 (comment):background-image: -webkit-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
- background-image: -moz-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
- background-image: -ms-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
- background-image: -o-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
background-image: linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));Oh, alrighty. Was not aware of that.
—
Reply to this email directly or view it on GitHub
https://github.com/mozilla/bedrock/pull/3240/files#r38007479.
Joseph Bywater / A Student
jabjab.co.uk@gmail.com
[image: Twitter] https://twitter.com/thejj100100 [image: Youtube]
https://www.youtube.com/user/TheJJ100100 [image: Instagram]
http://www.instagram.com/kiwifruitapple/ [image: flickr]
https://www.flickr.com/photos/129058144@N06/
There was a problem hiding this comment.
@alexgibson @schalkneethling I think I did anyway!
On 26 August 2015 at 18:18, Joseph Bywater jabjab.co.uk@gmail.com wrote:
@alexgibson @schalkneethling What happened? I did what I was told :P
On 26 August 2015 at 18:08, Schalk Neethling notifications@github.com
wrote:In media/css/sandstone/sandstone-resp.less
#3240 (comment):background-image: -webkit-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
- background-image: -moz-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
- background-image: -ms-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
- background-image: -o-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
background-image: linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));Oh, alrighty. Was not aware of that.
—
Reply to this email directly or view it on GitHub
https://github.com/mozilla/bedrock/pull/3240/files#r38007479.Joseph Bywater / A Student
jabjab.co.uk@gmail.com[image: Twitter] https://twitter.com/thejj100100 [image: Youtube]
https://www.youtube.com/user/TheJJ100100 [image: Instagram]
http://www.instagram.com/kiwifruitapple/ [image: flickr]
https://www.flickr.com/photos/129058144@N06/
Joseph Bywater / A Student
jabjab.co.uk@gmail.com
[image: Twitter] https://twitter.com/thejj100100 [image: Youtube]
https://www.youtube.com/user/TheJJ100100 [image: Instagram]
http://www.instagram.com/kiwifruitapple/ [image: flickr]
https://www.flickr.com/photos/129058144@N06/
There was a problem hiding this comment.
@TheJJ100100 - you didn't do anything, not to worry. The code is fine :)
There was a problem hiding this comment.
Oh, okay, I just got an email and it looked confusing!
|
Hah, so we only have |
|
Do we still actually need the http://codepen.io/chriscoyier/pen/zFoxn |
|
There are lots of mobile WebKit-based browsers that can't be updated still in the wild, so I think this last vendor prefix will be around for some time yet unfortunately. This is consistent with the level of support we're currently providing across the rest of the site. |
|
Ah bummer, in that case r+ |
…xed-gradients bug-1189121-remove-moz-expressions-from-bedrock
|
Thanks @schalkneethling! And thanks again for the PR @TheJJ100100 🍰 |
|
@schalkneethling @alexgibson Thanks for all the support! ;)
|
No description provided.