Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug-1189121-remove-moz-expressions-from-bedrock #3240

Merged
merged 2 commits into from Aug 26, 2015
Merged

bug-1189121-remove-moz-expressions-from-bedrock #3240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dc02e9
bug-1189121-remove-moz-expressions-from-bedrock
Aug 24, 2015
206af71
[bug 1189121] Remove old CSS vendor prefixes from gradient expressions
alexgibson Aug 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions media/css/facebookapps/downloadtab.less
View file
Open in desktop
Expand Up @@ -20,14 +20,8 @@
width: 790px;

background: #eaeff2;
background: -moz-radial-gradient(center, ellipse cover, rgba(234,239,242,1) 0%, rgba(212,221,228,.5) 60%),
-moz-linear-gradient(top, rgba(202,225,244,1) 0%, rgba(125,185,232,0) 100%);
background: -webkit-gradient(radial, center center, 0px, center center, 60%, color-stop(0%,rgba(234,239,242,.9)), color-stop(60%,rgba(212,221,228,.5))),
-webkit-linear-gradient(top, rgba(202,225,244,1) 0%, rgba(125,185,232,0) 100%);
background: -webkit-radial-gradient(center, ellipse cover, rgba(234,239,242,1) 0%, rgba(212,221,228,.4) 60%),
-webkit-linear-gradient(top, rgba(202,225,244,1) 0%, rgba(125,185,232,0) 100%);
background: -ms-radial-gradient(center, ellipse cover, rgba(234,239,242,1) 0%, rgba(212,221,228,.5) 60%),
-ms-linear-gradient(top, rgba(202,225,244,1) 0%, rgba(125,185,232,0) 100%);
background: radial-gradient(ellipse at center, rgba(234,239,242,1) 0%,rgba(212,221,228,.5) 50%),
linear-gradient(to bottom, rgba(202,225,244,1) 0%,rgba(125,185,232,0) 100%);
.border-radius(10px);
Expand Down
6 changes: 1 addition & 5 deletions media/css/firefox/mobile-sms.less
View file
Open in desktop
Expand Up @@ -95,12 +95,8 @@
text-shadow: 0 1px #333;
line-height: 1.2;
background-color: #aa1401;
background-image: -webkit-gradient(linear, left top, left bottom, from(rgba(218, 81, 50, 0.9)), to(rgba(169, 19, 0, 1)));
background-image: -webkit-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
background-image: -moz-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
background-image: -ms-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
background-image: -o-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
background-image: linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
background-image: linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
border-radius: 4px;
padding: 10px 15px;
box-shadow: 0 1px #666;
Expand Down
6 changes: 0 additions & 6 deletions media/css/firefox/new.less
View file
Open in desktop
Expand Up @@ -6,14 +6,8 @@

.sky #outer-wrapper {
background: #eaeff2;
background: -moz-radial-gradient(center, ellipse cover, rgba(234,239,242,1) 0%, rgba(212,221,228,.5) 60%),
-moz-linear-gradient(top, rgba(202,225,244,1) 0%, rgba(125,185,232,0) 100%);
background: -webkit-gradient(radial, center center, 0px, center center, 60%, color-stop(0%,rgba(234,239,242,.9)), color-stop(60%,rgba(212,221,228,.5))),
-webkit-linear-gradient(top, rgba(202,225,244,1) 0%, rgba(125,185,232,0) 100%);
background: -webkit-radial-gradient(center, ellipse cover, rgba(234,239,242,1) 0%, rgba(212,221,228,.4) 60%),
-webkit-linear-gradient(top, rgba(202,225,244,1) 0%, rgba(125,185,232,0) 100%);
background: -ms-radial-gradient(center, ellipse cover, rgba(234,239,242,1) 0%, rgba(212,221,228,.5) 60%),
-ms-linear-gradient(top, rgba(202,225,244,1) 0%, rgba(125,185,232,0) 100%);
background: radial-gradient(ellipse at center, rgba(234,239,242,1) 0%,rgba(212,221,228,.5) 50%),
linear-gradient(to bottom, rgba(202,225,244,1) 0%,rgba(125,185,232,0) 100%);

Expand Down
4 changes: 0 additions & 4 deletions media/css/sandstone/sandstone-resp.less
View file
Open in desktop
Expand Up @@ -518,11 +518,7 @@ select.error {
text-align: center;
line-height: 16px;
background-color: #aa1401;
background-image: -webkit-gradient(linear, left top, left bottom, from(rgba(218, 81, 50, 0.9)), to(rgba(169, 19, 0, 1)));
background-image: -webkit-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
background-image: -moz-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
background-image: -ms-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
background-image: -o-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
background-image: linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation here needs a fix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is intentional as per our CSS styleguide formatting

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, alrighty. Was not aware of that.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexgibson @schalkneethling What happened? I did what I was told :P

On 26 August 2015 at 18:08, Schalk Neethling notifications@github.com
wrote:

In media/css/sandstone/sandstone-resp.less
#3240 (comment):

 background-image: -webkit-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
  • background-image: -moz-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
  • background-image: -ms-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
  • background-image: -o-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
    background-image: linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));

Oh, alrighty. Was not aware of that.

—
Reply to this email directly or view it on GitHub
https://github.com/mozilla/bedrock/pull/3240/files#r38007479.

http://jab-jab.co.uk

Joseph Bywater / A Student
jabjab.co.uk@gmail.com

http://jab-jab.co.uk

[image: Twitter] https://twitter.com/thejj100100 [image: Youtube]
https://www.youtube.com/user/TheJJ100100 [image: Instagram]
http://www.instagram.com/kiwifruitapple/ [image: flickr]
https://www.flickr.com/photos/129058144@N06/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexgibson @schalkneethling I think I did anyway!

On 26 August 2015 at 18:18, Joseph Bywater jabjab.co.uk@gmail.com wrote:

@alexgibson @schalkneethling What happened? I did what I was told :P

On 26 August 2015 at 18:08, Schalk Neethling notifications@github.com
wrote:

In media/css/sandstone/sandstone-resp.less
#3240 (comment):

 background-image: -webkit-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
  • background-image: -moz-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
  • background-image: -ms-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
  • background-image: -o-linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));
    background-image: linear-gradient(top, rgba(218, 81, 50, 0.9), rgba(169, 19, 0, 1));

Oh, alrighty. Was not aware of that.

—
Reply to this email directly or view it on GitHub
https://github.com/mozilla/bedrock/pull/3240/files#r38007479.

http://jab-jab.co.uk

Joseph Bywater / A Student
jabjab.co.uk@gmail.com

http://jab-jab.co.uk

[image: Twitter] https://twitter.com/thejj100100 [image: Youtube]
https://www.youtube.com/user/TheJJ100100 [image: Instagram]
http://www.instagram.com/kiwifruitapple/ [image: flickr]
https://www.flickr.com/photos/129058144@N06/

http://jab-jab.co.uk

Joseph Bywater / A Student
jabjab.co.uk@gmail.com

http://jab-jab.co.uk

[image: Twitter] https://twitter.com/thejj100100 [image: Youtube]
https://www.youtube.com/user/TheJJ100100 [image: Instagram]
http://www.instagram.com/kiwifruitapple/ [image: flickr]
https://www.flickr.com/photos/129058144@N06/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheJJ100100 - you didn't do anything, not to worry. The code is fine :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okay, I just got an email and it looked confusing!

border-radius: 4px;
padding: 10px 15px;
Expand Down
5 changes: 1 addition & 4 deletions media/css/sandstone/video-resp.less
View file
Open in desktop
Expand Up @@ -43,10 +43,8 @@ a.mozilla-video-control-overlay {
left: 0;
width: 100%;
background: #444;
background: -webkit-gradient(radial,center center,0,center center,100%,from(#fff), to(#000));
background: -webkit-radial-gradient(center center, rgba(255,255,255,1) 0, rgba(0,0,0,0.9) 100%);
background: -moz-radial-gradient(center center, rgba(255,255,255,1) 0, rgba(0,0,0,0.9) 100%);
background: radial-gradient(center center, rgba(255,255,255,1) 0, rgba(0,0,0,0.9) 100%);
background: radial-gradient(center center, rgba(255,255,255,1) 0, rgba(0,0,0,0.9) 100%);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

z-index: 500;
outline: 0;
cursor: default;
Expand Down Expand Up @@ -135,4 +133,3 @@ a.mozilla-video-control-overlay {
}

/* }}} */

5 changes: 1 addition & 4 deletions media/css/sandstone/video.less
View file
Open in desktop
Expand Up @@ -40,10 +40,8 @@ a.mozilla-video-control-overlay {
left: 0;
width: 100%;
background: #444;
background: -webkit-gradient(radial,center center,0,center center,100%,from(#fff), to(#000));
background: -webkit-radial-gradient(center center, rgba(255,255,255,1) 0, rgba(0,0,0,0.9) 100%);
background: -moz-radial-gradient(center center, rgba(255,255,255,1) 0, rgba(0,0,0,0.9) 100%);
background: radial-gradient(center center, rgba(255,255,255,1) 0, rgba(0,0,0,0.9) 100%);
background: radial-gradient(center center, rgba(255,255,255,1) 0, rgba(0,0,0,0.9) 100%);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here :)

z-index: 500;
outline: 0;
cursor: default;
Expand Down Expand Up @@ -131,4 +129,3 @@ a.mozilla-video-control-overlay {
}

/* }}} */

6 changes: 1 addition & 5 deletions media/css/tabzilla/tabzilla.less
View file
Open in desktop
Expand Up @@ -727,12 +727,8 @@ html[dir="rtl"] {
#tabzilla-panel #tabzilla-nav a:focus,
#tabzilla-panel #tabzilla-nav a:active {
background: #43a6e2;
background: -moz-linear-gradient(top, #43a6e2 0%, #247ac1 100%);
background: -webkit-gradient(linear, left top, left bottom, color-stop(0%,#43a6e2), color-stop(100%,#247ac1));
background: -webkit-linear-gradient(top, #43a6e2 0%,#247ac1 100%);
background: -o-linear-gradient(top, #43a6e2 0%,#247ac1 100%);
background: -ms-linear-gradient(top, #43a6e2 0%,#247ac1 100%);
background: linear-gradient(top, #43a6e2 0%,#247ac1 100%);
background: linear-gradient(top, #43a6e2 0%,#247ac1 100%);
color: #fff;
text-shadow: 0 1px 1px rgba(0,0,0,.2);
text-decoration: none;
Expand Down