[bug 1397532] Minor updates to Quantum firstrun #5266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcook
force-pushed
the
bug-1397532-quantum-firstrun
branch
2 times, most recently
from
9b93577
to
65a9c82
Compare
alexgibson
requested changes
Nov 12, 2017
| @@ -24,48 +24,45 @@ | |||
| {% block site_header %}{% endblock %} | |||
|
|
|||
| {% block content %} | |||
| <div id="scene" xmlns:xlink= "http://www.w3.org/1999/xlink"> | |||
| <div id="scene"> | |||
There was a problem hiding this comment.
This <div> element is unclosed
|
Hrm, I do notice that the demo doesn't seem to load at all for me? https://www-demo4.allizom.org/en-US/firefox/57.0/firstrun/ Is that the same code as this branch? |
Oh nevermind, it was because I didn't have UITour enabled. |
Slow down animate-out of wave 3. Switch to common logo. Optimize SVGs. Give waves descriptive names. Fix wonky wave 7 in RTL. Use font-size mixin. Some general tidying. Add test.
craigcook
force-pushed
the
bug-1397532-quantum-firstrun
branch
from
65a9c82
to
887e28b
Compare
alexgibson
approved these changes
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few finishing touches to the firstrun page, primarily adjusting animation timing for one wave, switching to the standard logo, and some fixes for RTL. After that I just kept tweaking more things. Renamed the waves, used the font-size mixin, optimized the SVGs a bit more, added a basic test... nothing serious but lots of little touches. I couldn't help myself. I may have a problem.
Issue / Bugzilla link
https://bugzilla.mozilla.org/show_bug.cgi?id=1397532
Testing
Make sure everything still works.
https://www-demo4.allizom.org/firefox/57.0/firstrun/