Add language selection page (Fixes #5827) #6397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
added
Do Not Merge ⚠️
P2
alexgibson
commented
Nov 2, 2018
| @media #{$mq-sm} { | ||
| ul { | ||
| @include grid-gap($spacing-lg $spacing-xl); | ||
| display: grid; |
There was a problem hiding this comment.
Note for reviewer: as this page is so simple, I decided not to include a float/flex based fallback for browsers that don't support grid. Older browsers will just get a simple vertical list. I figured that this page is mainly for robots, so shouldn't matter too much. Happy to add a fallback if folks disagree, or we could update this page later to use the upcoming Protocol grid mixins.
rraue
approved these changes
Nov 2, 2018
|
Ok, I'm going to say this is now ready for code review, removing the dnm label. |
stephaniehobson
requested changes
Nov 7, 2018
| <section class="c-block-list"> | ||
| <h2 class="c-block-list-title">America</h2> | ||
| <ul> | ||
| <li><a href="/cak/">Maya Kaqchikel</a></li> |
There was a problem hiding this comment.
Each language should have a lang attribute associated with it, you can put it on the <li> or the <a>.
There was a problem hiding this comment.
Great suggestion, will do!
| @media #{$mq-sm} { | ||
| ul { | ||
| @include grid-gap($spacing-lg $spacing-xl); | ||
| display: grid; |
alexgibson
force-pushed
the
language-selector-page
branch
from
75da4eb
to
3b2bba2
Compare
|
Thanks @stephaniehobson updated |
stephaniehobson
approved these changes
Nov 8, 2018
|
R+ 🌎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/locales/.Note: will file an issue to research automation for this list post-launch.
Issue / Bugzilla link
#5827
Testing
Demo: https://bedrock-demo-agibson.oregon-b.moz.works/locales/