Add history of web browser page (Fixes #6709) #6764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
added
Do Not Merge ⚠️
P2
|
Do not merge until we get stakeholder approval. |
alexgibson
force-pushed
the
browser-history-page
branch
from
30ea90d
to
e54d652
Compare
|
Rebased |
|
@alexgibson - we are stakeholder approved now, I've removed the DNM tag. |
alexgibson
force-pushed
the
browser-history-page
branch
from
e54d652
to
f6777da
Compare
5 tasks
|
I'm not quite clear if there are copy changes to be made here, so adding back the dnm label for now. |
|
@alexgibson - Copy is unchanged. Apologies if I presented any confusion. This is good to go. |
|
@ejregithub ok thanks for confirming :) This is good for review again. |
amychurchwell
suggested changes
Feb 4, 2019
|
Thanks @amychurchwell good suggestion, updated 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/technology/browser-history//technology/update-browser/page:Issue / Bugzilla link
#6709
Testing
Demo: https://bedrock-demo-agibson.oregon-b.moz.works/en-US/technology/browser-history/