Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling "report a problem" displays as if problem was reported #71

Closed
rbillings opened this issue Jul 29, 2016 · 9 comments
Closed

Comments

@rbillings
Copy link
Collaborator

Opening "report a problem" and then closing the modal or clicking Cancel updates the page header to "You have reported a problem".

@groovecoder
Copy link
Member

Currently, when the user clicks "Report a problem" we send a "page-problem" telemetry ping. When the user enters details about how the page is broken, we send a "breakage" telemetry ping. So, technically, the display is correct: The user did report "a problem" even though they didn't provide any breakage details.

@ashgrigas - Assuming we still want to allow users to report page problems even if they don't provide any breakage details, should we change copy and/or UX to make this more clear?

@ashgrigas
Copy link

can we add the word (optional) after the free form text field descriptor text?

@groovecoder
Copy link
Member

@ashgrigas yup, that's easy. Do we think that's enough? Or should we put "optional" in the title of the modal to indicate that the entire modal is optional?

@ashgrigas
Copy link

I would think we would want them to at least choose a radio button at
minimum?

On Wed, Aug 3, 2016 at 12:46 PM, luke crouch notifications@github.com
wrote:

@ashgrigas https://github.com/ashgrigas yup, that's easy. Do we think
that's enough? Or should we put "optional" in the title of the modal to
indicate that the entire modal is optional?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#71 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AI_-mNb3pS1gDMD5M-aOq8Qlo5FGiVlSks5qcMXWgaJpZM4JYT6F
.

Aislinn Dewey Grigas
User Experience Design Consultant
www.aislinndewey.com

978.930.3729

http://www.linkedin.com/in/aislinn http://www.twitter.com/ashdewey
http://www.facebook.com/ashdewey

@groovecoder
Copy link
Member

If they submit breakage details, yes - we require them to at least choose a radio button.

This issue is:

When a user clicks "Report a problem" and then clicks "Cancel" or closes the modal without submitting any details, they still see "You reported a problem on the page" in the notification bar.

blok-report-cancel

It's technically accurate and true - they did indeed report a problem on the page, which we recorded via telemetry. But they didn't give us any details.

So the question is: [how can|should] we change the UI to make it more clear to the user that they did report a problem, even though they didn't give us breakage details.

@ashgrigas
Copy link

So I guess I don't think it would be clear to users if they clicked the X
or cancel that they actually reported a problem. I think we should change
the recording so it isnt a telemetry record when the X/cancel is clicked -
only if they actually hit submit. The notificaiton bar then would stay in
its original state...

On Wed, Aug 3, 2016 at 2:11 PM, luke crouch notifications@github.com
wrote:

If they submit breakage details, yes - we require them to at least choose
a radio button.

This issue is:

When a user clicks "Report a problem" and then clicks "Cancel" or closes
the modal without submitting any details, they still see "You reported a
problem on the page" in the notification bar.

[image: blok-report-cancel]
https://cloud.githubusercontent.com/assets/71928/17376290/9a7e8d52-597a-11e6-8cd9-6a2b934a3894.gif

It's technically accurate and true - they did indeed report a problem on
the page, which we recorded via telemetry. But they didn't give us any
details.

So the question is: [how can|should] we change the UI to make it more
clear to the user that they did report a problem, even though they
didn't give us breakage details.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#71 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AI_-mJ0T9R-bNp8fVzj2nJLx4ENAqQiaks5qcNnFgaJpZM4JYT6F
.

Aislinn Dewey Grigas
User Experience Design Consultant
www.aislinndewey.com

978.930.3729

http://www.linkedin.com/in/aislinn http://www.twitter.com/ashdewey
http://www.facebook.com/ashdewey

@groovecoder
Copy link
Member

groovecoder commented Aug 3, 2016

We don't actually send a telemetry ping when the X/cancel are clicked; we do send a telemetry ping as soon as they click the [works|problem] button. We have 3 total separate telemetry pings.

page broken

When the user clicks "Report a problem" we send:

{
        originDomain: currentActiveOrigin,
        trackerDomains: blockedRequests[currentActiveTabID],
        feedback: "page-broken"
}

page works

When the user clicks "This page works well" we send:

{
        originDomain: currentActiveOrigin,
        trackerDomains: blockedRequests[currentActiveTabID],
        feedback: "page-works"
}

breakage

When the user clicks "Submit" in the feedback modal, we send:

{
        originDomain: currentActiveOrigin,
        trackerDomains: blockedRequests[currentActiveTabID],
        breakage: [images|video|layout|buttons|other],
        notes: [notes]
}

The page-works and page-broken telemetry pings seem valuable even if the user doesn't submit breakage details. I.e. - we can still learn the most-broken sites and the most-breakage-causing trackers. And we can manually check the most-broken sites ourselves to see what's broken.

So, I suggest we keep all 3 of the pings and update the copy to make it clear to the user that they are reporting feedback/data as soon as they click the first buttons, and that the modal is for optional breakage details.

@groovecoder
Copy link
Member

@johngruen - what do you think? Should we keep all 3 of these telemetry pings?

@groovecoder
Copy link
Member

This became #88 and there's now a PR in for it. #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants