Fix #1907: menus don't have a dark theme anymore #670
Conversation
| @@ -237,6 +237,7 @@ define(function (require, exports, module) { | |||
| return result.content; | |||
| }) | |||
| .then(function (cssContent) { | |||
| $("body").toggleClass("dark", theme.dark); | |||
There was a problem hiding this comment.
this fix seems to assume a binary theme choice in that if there is any theme at all, it must be the dark theme. That will break the moment we introduce a third theme, or custom theming, so it would be better to check which theme should actually be active. Maybe @flukeout can help point in the right direction here
|
We intentionally moved away from the using classes to set the theme, and opted for a data-theme attribute on the body instead. We may have more than two themes in the future, so the dark / not-dark binary choice doesn't make sense for the long term. Maybe we can add an override to the quickEdit CSS so that it respects the Cheers! |
|
After thinking a bit more and chatting with @Pomax - this will be the way we handle it for now. Brackets basically has a hard-coded notion of having a 'dark theme' and the |
This fix fixes Thimble issue https://github.com/mozilla/thimble.mozilla.org/issues/1907
This line was erased in one of the previous PRs : $("body").toggleClass("dark", theme.dark);
Putting it back resolved the issue. I did some local testing to make sure nothing broke, everything seemed okay.