Fix #736: Drop xorigin.js and dependencies.js to reduce startup time #741
Conversation
src/main.js
Outdated
| @@ -120,6 +120,22 @@ if ('serviceWorker' in window.navigator) { | |||
| }); | |||
| } | |||
|
|
|||
| window.setTimeout(function () { | |||
There was a problem hiding this comment.
I want to avoid this. A better way for us to do this is to take the HTML you have below, and insert it into a <div id="iframe-warning">..</div> inside the spinner container, here. You can add some CSS to the inline style block to hide this div by default. Then, when your JS runs, if we enter the if block you have on 129`, we can show the error (e.g., add/change the CSS class on the div) and skip loading Bramble.
There was a problem hiding this comment.
I'll be home tonight at 8 I'll work on this tonight and get it changes asap!
There was a problem hiding this comment.
@humphd some progress
Edit 1 Ok fixed
There was a problem hiding this comment.
@humphd ok everything should be fixed, and pushed let me know if there are anymore changes. :) I tested again and working across all 3 browsers
|
@humphd any news? :) |
src/index.html
Outdated
| @@ -57,6 +57,9 @@ | |||
| */ | |||
| outline: 1px solid transparent; | |||
| } | |||
| #iframe-warning { | |||
| visibility: hidden; | |||
| } | |||
There was a problem hiding this comment.
Let's add padding: 20px; to this too, so it isn't so tight to the edge of the window.
src/main.js
Outdated
| ); | ||
| } | ||
| }, 1000); | ||
| } |
There was a problem hiding this comment.
Probably we should throw this remaining code in an else block, since it's not worth doing if the first if happens.
There was a problem hiding this comment.
I'm not sure what you mean? isn't the if statement required to check to see if it's within iFrame? I don't see us doing it anywhere else? @humphd
Edit: ah ok I get what you mean:)
|
@humphd I hope I understood what you meant, I basically moved the if statement to the top, then added an else for the rest of the code. This way it only executes if within iframe. |
|
@humphd hey any news on this bug? :) |
|
It's on our radar, but not part of what we're shipping next week. After that I'll circle back. |
|
Alright keep me posted. |
|
I've finished this in #779. |
Should be working fine. I had to use window.setTimeout to avoid the following error:
Let me know if I'm missing comments or if there are any problems.
#736
Edit:
slimmed down the code a bit. I could get rid of str, but kept it because it's easier on the eyes:)