You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Brackets loads two separate JS files on startup that really aren't needed by us. I'd like to delete them, and put some of what they do in other files. Here's what I need done:
src/xorigin.js
Remove this file (git rm) and all references to it:
Once again, test that everything works. Make sure you test loading Brackets in both of the follow ways, the first should show your error, the second should work:
http://localhost:8000/src/index.html should show the error about the iframe
http://localhost:8000/src/hosted.html should allow the editor to load and not show the error about the iframe.
I'm assigning this bug to @Th30, who still needs a bug for his 0.4 release.
The text was updated successfully, but these errors were encountered:
Brackets loads two separate JS files on startup that really aren't needed by us. I'd like to delete them, and put some of what they do in other files. Here's what I need done:
src/xorigin.js
Remove this file (
git rm
) and all references to it:Test that you can still load Brackets successfully by starting the server (
npm start
) and browsing tohttp://localhost:8000/src/hosted.html
src/dependencies.js
Take the code at https://github.com/mozilla/brackets/blob/master/src/dependencies.js#L49-L59 and rework it to live here: https://github.com/mozilla/brackets/blob/master/src/main.js#L122. Basically, I want a check to make sure we're running in an iframe, and if not, we
document.write
that error message. If we are running in aniframe
, then you can continue to run thedefine()
block (e.g., use anif/else
or something for the two cases).Once you've done that,
git rm
thesrc/dependencies.js
file, and remove all references to it:Once again, test that everything works. Make sure you test loading Brackets in both of the follow ways, the first should show your error, the second should work:
http://localhost:8000/src/index.html
should show the error about the iframehttp://localhost:8000/src/hosted.html
should allow the editor to load and not show the error about the iframe.I'm assigning this bug to @Th30, who still needs a bug for his 0.4 release.
The text was updated successfully, but these errors were encountered: