Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github actions workflows- Should they be used? #3765

Open
unna97 opened this issue Oct 27, 2023 · 3 comments
Open

Github actions workflows- Should they be used? #3765

unna97 opened this issue Oct 27, 2023 · 3 comments

Comments

@unna97
Copy link

unna97 commented Oct 27, 2023

Related Pull request:: #3763
@unna97
Copy link
Author

unna97 commented Oct 27, 2023 •
edited
Loading

@suhaibmujahid Added the issue here.

@suhaibmujahid
Copy link
Member

@suhaibmujahid Add the issue here.

Thank you! It is supposed to link the PR to the issue, not the otherway.

Regarding the title of the issue, I would reserve it to state the goal or the problem that we want to solve. The motivation and suggested solutions could be explained in the description.

@unna97 unna97 changed the title Add github actions workflow files that allow testing on different environment combinations through a workflow dispatch Github actions workflows Oct 28, 2023
@unna97 unna97 changed the title Github actions workflows Github actions workflows: Oct 28, 2023
@unna97 unna97 changed the title Github actions workflows: Github actions workflows Oct 28, 2023
@unna97
Copy link
Author

unna97 commented Oct 28, 2023 •
edited
Loading

As mentioned in the discussion , the team needs to discuss whether github actions should be used in the project. Reasons I believe the github actions should be used:

  1. Confirmation of the fact that the failure is not due OS or python version on latest changes.
  2. Automatic pre-commit
  3. More widely used so better documentation
  4. Replicable commands

@unna97 unna97 changed the title Github actions workflows Github actions workflows- Should they be used? Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@suhaibmujahid @unna97