Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional City field has no charcter limit #122

Closed
DPX-designer opened this issue Nov 27, 2019 · 3 comments
Closed

Optional City field has no charcter limit #122

DPX-designer opened this issue Nov 27, 2019 · 3 comments
Labels
bug Something isn't working pr ready

Comments

@DPX-designer
Copy link

In the City (optional) field it is possible to enter a hefty amount of text, perhaps we should cap this.

Wikipedia tells me the longest place name is:

Krungthepmahanakhon Amonrattanakosin Mahintharayutthaya Mahadilokphop Noppharatratchathaniburirom Udomratchaniwetmahasathan Amonphimanawatansathit Sakkathattiyawitsanukamprasit (176 letters)
In Thailand.

So maybe 180 is a good maximum? What I have below is 798.

Screenshot 2019-11-27 at 11 14 05

Screenshot 2019-11-27 at 11 13 33
@dnaluz
Copy link
Collaborator

dnaluz commented Nov 27, 2019

Yeah 180 sounds good. Will implement

@dnaluz dnaluz added bug Something isn't working pr ready labels Nov 27, 2019
@dnaluz
Copy link
Collaborator

dnaluz commented Nov 27, 2019

PR #124

@dnaluz
Copy link
Collaborator

dnaluz commented Nov 27, 2019

Fix is live!

@dnaluz dnaluz closed this as completed Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pr ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dnaluz @DPX-designer