Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content_script.js blocks the main thread of the content process scanning the entire document for elements that, for most pages, aren't there #544

Open
mikeconley opened this issue Nov 8, 2019 · 0 comments · May be fixed by #877
Labels
🐛 bug Something isn't working needs-priority This issue needs prioritization

Comments

@mikeconley
Copy link

Here are the CSS selectors for the things that the add-on scans for.

A number of these queries are site-specific - however, it looks like we scan every page for them. I suspect we can skip a lot of this scanning by checking the domain that we're on, and culling rules that don't apply. I believe that would eliminate all but 2 of the LOGIN_PATTERN_DETECTION_SELECTORS selectors, and all but 1 of the SHARE_PATTERN_DETECTION_SELECTORS selectors.

@maxxcrawford maxxcrawford added the P1 must fix before shipping label Dec 16, 2019
@maxxcrawford maxxcrawford added needs-priority This issue needs prioritization 🐛 bug Something isn't working and removed P1 must fix before shipping labels Aug 10, 2020
@marcustyphoon marcustyphoon linked a pull request Oct 2, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working needs-priority This issue needs prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants