Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

Add 'chat' to the 'participate' object #107

Merged
merged 2 commits into from
Feb 12, 2020

Conversation

jaywink
Copy link
Contributor

@jaywink jaywink commented Feb 11, 2020

The 'chat' object if given must supply an URL form
reference to a chat for the project. Optionally
it can also supply contacts in that chat.

I didn't add any examples except the IRC channel ref
that was already in the readme. I also didn't remove
the IRC keys. Possibly they could be removed immediately
since the spec is not guaranteed according to the readme
to be stable but possibly they should be removed only
after Observatory supports the new chat key and Mozilla
sites have had time to roll over so they don't suffer a bad
Observatory rating?

Also add chat.mozilla.org contribute.json to the list.
Note currently it contains the IRC keys, since
Mozilla Observatory will otherwise give -5 points
until a Matrix chat room reference can be given to
point to the right Riot Web related room.

Closes #106

The 'chat' object if given must supply an URL form
reference to a chat for the project. Optionally
it can also supply contacts in that chat.
Note currently it contains the IRC keys, since
Mozilla Observatory will otherwise give -5 points
until a Matrix chat room reference can be given to
point to the right Riot Web related room.
@@ -16,3 +16,4 @@ https://raw.githubusercontent.com/mozilla/configman/master/contribute.json
https://nightly.mozilla.org/contribute.json
https://firefox.settings.services.mozilla.com/v1/contribute.json
https://contrast-finder.org/contribute.json
https://chat.mozilla.org/contribute.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THat one hasn't changed yet :)

Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna take a look too @pmac ?

Copy link
Member

@pmac pmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@peterbe peterbe merged commit a288196 into mozilla:master Feb 12, 2020
@jaywink jaywink deleted the participate-chat branch February 13, 2020 16:00
@peterbe peterbe mentioned this pull request Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-IRC chat references
3 participants