Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flickr rule hides the wrong element #24

Closed
jaredhirsch opened this issue Nov 9, 2022 · 2 comments
Closed

flickr rule hides the wrong element #24

jaredhirsch opened this issue Nov 9, 2022 · 2 comments
Labels
broken-rule Cookie banner is not handled on a site because of a broken or outdated rule. QA Verified Issues was verified by the QA as no longer reproducible.

Comments

@jaredhirsch
Copy link
Member

jaredhirsch commented Nov 9, 2022 •
edited
Loading

The flickr rule hides the cookie banner element (.truste_box_overlay_inner), but not the translucent dark overlay that sits beneath the cookie banner (.truste_overlay), so that the site looks odd.

With banner auto-hidden:

Screenshot 2022-11-09 at 3 03 39 PM

Correct appearance, with div.truste_overlay hidden as well as div.truste_box_overlay_inner:

Screenshot 2022-11-09 at 3 05 06 PM

Note that the DOM structure requires us to hide two sibling elements whose parent element is the body el:

<body>
  ... lots of stuff ...
  <div class="truste_overlay"></div>
  <div class="truste_box_overlay">
    <div class="truste_box_overlay_inner">

I wonder if it might make sense to target the truste_box_overlay instead of truste_box_overlay_inner.
@Trikolon Trikolon added the broken-rule Cookie banner is not handled on a site because of a broken or outdated rule. label Nov 9, 2022
@jaredhirsch
Copy link
Member Author

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1800908 to pick up the hiding multiple nodes discussion in BMO

@pdehaan pdehaan mentioned this issue Nov 30, 2022
Closed
@Softvision-ValentinBandac Softvision-ValentinBandac added the QA Verified Issues was verified by the QA as no longer reproducible. label Dec 21, 2022
@Softvision-ValentinBandac
Copy link
Collaborator

I have verified that this issue is no longer reproducible using the latest V0.5.6 release on RS stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
broken-rule Cookie banner is not handled on a site because of a broken or outdated rule. QA Verified Issues was verified by the QA as no longer reproducible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaredhirsch @Trikolon @Softvision-ValentinBandac