Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resampler fill method unused frames "trap" #185

Open
achronop opened this issue Nov 7, 2016 · 0 comments
Open

Resampler fill method unused frames "trap" #185

achronop opened this issue Nov 7, 2016 · 0 comments

Comments

@achronop
Copy link
Contributor

achronop commented Nov 7, 2016

The unused frames from method cubeb_resampler_fill depending on the cubeb_resampler instance. The noop_resampler resampler does not buffer any of the frames internally so it is expected to have remaining frames. On the other hand the cubeb_resampler_speex resampler buffers internally all input frames and uses them in following iterations as needed. In that case it is not expected to have any left over frames after fill.

I raise this issue first to let you know about the case and second to find a way to make resampler behavior more uniform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant