This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
Footer and font changes #2030
Merged
Footer and font changes #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kristinashu review app should be done soon. This is footer layout changes. Re assign to a dev for review if it looks good. |
|
Looks fine but can you please make the mozilla logo link to http://foundation.mozilla.org/ |
|
@kristinashu is there a ticket for this? Maybe just drop in the redpens. |
|
There was no ticket or design for this. It was the compromise between having the Foundation site footer layout and donate page content. |
gvn
approved these changes
Jul 10, 2018
|
Tiny regression in RTL, this block of text should be aligned on the right
|
|
@TheoChevalier updated. |
|
Thanks! Looks good 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.