This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
Better makefile #467
Merged
Better makefile #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Confirmed: nunjucks is broken atm. Working on it.) |
You can now run "make" with impunity. * It will no longer run `npm install` if it doesn't need to, so it will be fast and not hit the network. * It will rebuild the nunjucks templates if necessary and leave them alone otherwise. You don't need to call `make templates` manually anymore (though it continues to exist so the deploy process can call it and not bother compiling the clang plugin). * `make clean` now removes the installed node modules. Move the client-side templates into a nunjucks folder so we can find them all with a glob. The "partial" folder didn't have a well-defined semantic.
…de to nunjucks 2.0. We never used any of that gadgetry. We can reintroduce the pieces we need when we get around to a JS test harness. Until then, we can enjoy lighter-weight installs. WTF: Why no shasums for certain packages?
erikrose
force-pushed
the
better-makefile
branch
from
453e2a4
to
0d77d1e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f? I haven't tested the JS yet.
Makefile is now sane. You can run "make" with impunity.
npm installif it doesn't need to, so it will be fast and not hit the network.make templatesmanually anymore (though it continues to exist so the deploy process can call it and not bother compiling the clang plugin).make cleannow removes the installed node modules.Also upgrade nunjucks to 2.0 and npm-lockdown to 0.0.6.
Also also remove Grunt, so we only need 5MB of node modules rather than 30MB.