Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the link for bugs #303

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Updates the link for bugs #303

merged 1 commit into from
Aug 21, 2019

Conversation

mahimas28
Copy link
Contributor

@mahimas28 mahimas28 commented Aug 21, 2019

Fixes - #246
cc - @championshuttler

@mahimas28 mahimas28 marked this pull request as ready for review August 21, 2019 16:22
Copy link
Collaborator

@championshuttler championshuttler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mahimas28! Looks good to me. Lets wait for final approval. Also it would be nice to add Fixes #Issue No. , it would close the issue as this PR will be merged. You can read more about it here https://help.github.com/en/articles/closing-issues-using-keywords

Copy link
Contributor

@caitmuenster caitmuenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @mahimas28! 🎉

@caitmuenster caitmuenster merged commit b14190f into mozilla:master Aug 21, 2019
@caitmuenster
Copy link
Contributor

Hi @mahimas28 , sorry for the late notification but I have just added your contribution to our recognition wiki. :) Thanks again for your patch!

Would you be interested in creating a profile on mozillians.org? I'd be happy to vouch for you!

@mahimas28
Copy link
Contributor Author

Yes sure @caitmuenster :) Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants