Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to be able to timeout ruleset execution #75

Open
crankycoder opened this issue Oct 6, 2017 · 4 comments
Open

Need to be able to timeout ruleset execution #75

crankycoder opened this issue Oct 6, 2017 · 4 comments

Comments

@crankycoder
Copy link

It is possible to define rulesets which run very slowly on some webpages.

This currently causes performance problems in Firefox (I'm currently testing on 58).

I think we should be able to mitigate this problem if Fathom supported a way to timeout ruleset execution after X ms.

In my head, I'd like something like a callback system where I can pass in a function that accepts the current runtime in ms of the ruleset. Returning a non-zero value should cause the fathom ruleset to abort early.

@danielhertenstein
Copy link
Collaborator

@erikrose: How does that changeset (emitting markup) address this issue?

@erikrose
Copy link
Contributor

Apparently, when I imported the FathomFox issues, it fired off the triggers to take action on any mentioned ticket IDs. But the IDs really refer to the FathomFox repo. So I'll have to go through these and say "nuh uh!"

Nuh uh!

@erikrose erikrose reopened this Mar 25, 2020
@danielhertenstein
Copy link
Collaborator

That's unfortunate.

@erikrose
Copy link
Contributor

erikrose commented Mar 25, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants