This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
better preview lightbox check on app details (bug 1166273) #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Don't show on desktop detail since it'd show the previews at | ||
| // the same size. | ||
| if (!isDesktopDetail()) { | ||
| var isVideo = e.target.nodeName === 'VIDEO'; |
There was a problem hiding this comment.
would probably move all the isVideo logic into one block if it makes sense too...:
if (!isVideo || !isDesktopDetail() && isVideo) {
e.preventDefault();
}
|
r+ |
spasovski
added a commit
that referenced
this pull request
May 21, 2015
better preview lightbox check on app details (bug 1166273)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On desktop app details...don't open lightbox but play video.
On mobile app details...always open lightbox.
On listing pages...always open lightbox.