Don't populate the search box with the category name (Bug 982668) #401
Conversation
| @@ -11,7 +11,7 @@ define('views/featured', ['urls', 'z'], function(urls, z) { | |||
| } | |||
|
|
|||
| builder.z('type', 'search'); | |||
| builder.z('search', params.name || category); | |||
| builder.z('search', params.name); | |||
| builder.z('title', params.name || category); | |||
There was a problem hiding this comment.
should this say "games"? http://localhost:8675/category/games/featured?src=category-featured
There was a problem hiding this comment.
I'm guessing it shouldn't. I have removed the category from the title as well.
There was a problem hiding this comment.
well now the title is blank? is that what we want? I think we want the category title
There was a problem hiding this comment.
Ok fair enough. I can add it back in. I figured since you mentioned it, it shouldn't. Is there anything else to be done to see this merged?
|
r+wc |
|
It looks like this didn't merged and needs resolving to avoid the conflict, if we get this rebased, would it be ok to merge? @cvan |
|
Oh sorry this merges cleanly, but breaks the build. |
|
@nearlyfreeapps Thanks for this! Sorry for the delay. I rebased it and committed it on a separate pull to avoid some build errors: #464 |
In Bug 982668, it is noted that the search box gets populated with the category name after clicking the 'View All' link on a featured app collection. This should prevent that from happening.