Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

Added title attrs to facilitate reading long lines (bug 1079172). #700

Merged
merged 1 commit into from Oct 7, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/templates/_macros/feed_item.html
Expand Up @@ -12,8 +12,8 @@
<a href="{{ url('app', [app.slug])|urlparams(src=src or 'feed') }}" class="app-link c">
{{ deferred_icon(app.icons[64], app.name|translate(app)) }}
<div class="info">
<h2 class="app-name elliflow">{{ app.name|translate(app) }}</h2>
<p class="author elliflow">{{ app.author }}</p>
<h2 class="app-name elliflow" title="{{ app.name|translate(app) }}">{{ app.name|translate(app) }}</h2>
<p class="author elliflow" title="{{ app.author }}">{{ app.author }}</p>
<div class="rating vital{{ ' unrated' if not app.ratings.count }}" itemprop="aggregateRating" itemscope itemtype="http://schema.org/AggregateRating">
{% if app.ratings.average %}
{{ stars(app.ratings.average) }}
Expand Down
11 changes: 6 additions & 5 deletions src/templates/_macros/market_tile.html
Expand Up @@ -23,12 +23,12 @@
data-slug="{{ app.slug }}"
data-id="{{ app.id }}"
{% if link %}itemscope itemtype="http://schema.org/SoftwareApplication"{% endif %}>
{{ deferred_icon(app.icons['64']) }}
{{ deferred_icon(app.icons['64'], app.name|translate(app)) }}
<div class="info">
<h3 class="elliflow" itemprop="name">{{ app.name|translate(app) }}</h3>
<h3 class="elliflow" itemprop="name" title="{{ app.name|translate(app) }}">{{ app.name|translate(app) }}</h3>
{% if app.author %}
{# TODO: When we get user profiles, update this to be a proper Person itemprop #}
<div class="author elliflow vital subdetail" itemprop="creator">
<div class="author elliflow vital subdetail" itemprop="creator" title="{{ app.author }}">
{% if not link -%}
<a href="{{ url('search')|urlparams(author=app.author) }}">{{ app.author }}</a>
{% else -%}
Expand Down Expand Up @@ -103,9 +103,10 @@ <h3 class="elliflow" itemprop="name">{{ app.name|translate(app) }}</h3>
{% if not imgAlreadyDeferred(src) %}
{# Defer image loading. #}
<img class="icon deferred" src="{{ PLACEHOLDER_ICON }}"
data-src="{{ src }}" alt="{{ alt or '' }}" height="64" width="64" itemprop="image">
data-src="{{ src }}" title="{{ alt or '' }}" alt="{{ alt or '' }}"
height="64" width="64" itemprop="image">
{% else %}
<img class="icon" src="{{ src }}" alt="{{ alt or '' }}"
<img class="icon" src="{{ src }}" title="{{ alt or '' }}" alt="{{ alt or '' }}"
height="64" width="64" itemprop="image">
{% endif %}
{% endmacro %}
Expand Down