This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Only register one FxA message handler (bug 1080347) #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -105,6 +105,13 @@ define('login', | |||
| } | |||
| })); | |||
|
|
|||
| window.addEventListener('message', function (msg) { | |||
| if (!msg.data || !msg.data.auth_code || msg.origin !== settings.api_url) { | |||
There was a problem hiding this comment.
shouldn't we check capabilities.fallbackFxA()?
There was a problem hiding this comment.
This should never get called if that's the case so I guess we can skip registering this then. We'll need to wait for site_config to load first though.
|
r+ if you add a check for fallback fxa to add the handler |
| @@ -306,6 +309,7 @@ define('login', | |||
| // This lets us change the cursor for the "Sign in" link. | |||
| persona_def.reject(); | |||
| z.body.addClass('persona-loaded'); | |||
| registerFxAPostMessageHandler(); | |||
There was a problem hiding this comment.
why can this not happen in startLogin?
There was a problem hiding this comment.
Because it will register a callback each time startLogin is called and we'll send the token to zamboni as many times as you've clicked "Sign In" this session.
There was a problem hiding this comment.
it would probably help if you indicated what you want the comment to say :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1080347
Register the FxA message handler when
login.jsis loaded instead of when the "Sign In" button is clicked so we only ever register one handler.