This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
refresh app detail page pt.1, app header (bug 1103201) #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
force-pushed
the
feed-detail
branch
2 times, most recently
from
88ec565
to
2e5498c
Compare
ngokevin
changed the title
ngokevin
force-pushed
the
feed-detail
branch
2 times, most recently
from
d08dfb2
to
e420475
Compare
|
This is what I see on mobile: |
|
my bad need to rebase |
|
sorry about that. re-r? the other detail PRs depend on this one |
|
Seems like the stars could use something akin to |
|
Still see the unpadded header on mobile but not sure if it needs attention since it seems addressed in your subsequent PRs. |
|
r+wc |
ngokevin
force-pushed
the
feed-detail
branch
3 times, most recently
from
61ab0a9
to
e10a416
Compare
ngokevin
added a commit
that referenced
this pull request
Jan 7, 2015
refresh app detail page pt.1, app header (bug 1103201)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mock: https://www.dropbox.com/sh/7v0lv4rm70139o7/AACc_XBUl2TC5ALeR9ksdunQa
This focuses on the app tile portion of the app detail page, i.e., the top.
.listingfrom detail page, have preview trays use.trayover.mkt-tile .tray|replace('64.png', '128.png')