This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Don't show the update notification banner on the website (bug 1114794) #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -151,7 +151,9 @@ function(_) { | |||
| // are in a packaged app, wait for the iframe to be loaded, otherwise | |||
| // we are using the direct installer and we just need to wait for the | |||
| // normal loaded event. | |||
| var event_for_apps = window.location.protocol === 'app:' ? 'iframe-install-loaded' : 'loaded'; | |||
| var is_packaged_app = window.location.protocol === 'app:'; | |||
| var is_iframed_app = window.top != window.self; // Crude, but enough for our needs. | |||
There was a problem hiding this comment.
we have a capabilities.yulelogFxA which does the same iframe check but also checks a waffle.
and we do the same iframe check again in the webactivities module.
perhaps you could consolidate? might need to check it again in more places in the future.
There was a problem hiding this comment.
I updated to use !==. I've filed another bug to clean up the iframe checks, it will be easier as we might need to cherry-pick this one. https://bugzilla.mozilla.org/show_bug.cgi?id=1117771
|
r+wc |
diox
force-pushed
the
dont-show-update-notification-on-website
branch
2 times, most recently
from
dc42d6b
to
b77cfc7
Compare
diox
added a commit
that referenced
this pull request
Jan 5, 2015
…bsite Don't show the update notification banner on the website (bug 1114794)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1114794