Skip to content
This repository has been archived by the owner on Jan 31, 2018. It is now read-only.

[bug 843732] Capture src in source field #222

Merged
merged 1 commit into from
Feb 20, 2014
Merged

[bug 843732] Capture src in source field #222

merged 1 commit into from
Feb 20, 2014

Conversation

willkg
Copy link
Member

@willkg willkg commented Feb 20, 2014

r?

@willkg
Copy link
Member Author

willkg commented Feb 20, 2014

It's pretty straight forward. If there's a src= querystring parameter, we truncate it to 30 characters and stick it in the db.

At some later point (and under a different bug), we'll validate the src parameter against campaigns or something like that.

There's no way to view the source on the site, yet. Once someone figures out how they want to do that, we can do that on the site.

@willkg
Copy link
Member Author

willkg commented Feb 20, 2014

^^^ Redoes the PR to handle utm_source and utm_campaign.

@rlr
Copy link
Contributor

rlr commented Feb 20, 2014

I ran the tests, did manual tests with different combinations and verified the values in the admin.
r+!

@willkg willkg merged commit 878db23 into mozilla:master Feb 20, 2014
@willkg
Copy link
Member Author

willkg commented Feb 20, 2014

Landed in 878db23 [bug 843732] Handle utm_source and utm_campaign

@willkg willkg deleted the 843732-capture-src branch February 20, 2014 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants